-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nice in systemd unit is always 5 #229
Comments
This is right, I can see in resticprofile/systemd/generate.go Line 121 in 3476fbc
Thanks for the report 👍🏻 |
Hello,
also will create restic instances with the default niceness.
Edit: resticprofile itself respects the setting, only the restic instances are started at the default niceness. |
Can confirm, I'm seeing this too.
Now, I'm no Go programmer, and only somewhat familiar with the Unix/Linux API, but it looks to me as if you're creating a process group, but then setting the niceness only for the current process and not the group in https://github.com/creativeprojects/resticprofile/blob/master/priority/linux.go#L52-L60: err = unix.Setpriority(unix.PRIO_PROCESS, pid, priority) Could using |
Well spotted! If you guys are ok with compiling go code, can you try again with this MR? #339 (This is a fix when running from the terminal, not from |
Hello again! #339 seems to work for me! |
Hello
I noticed that
nice
in global section is not correctly passed to systemd unit template.for example with this config
After running
schedule
the systemd unit file isNice is set to 5 and not to 17 as expected
The text was updated successfully, but these errors were encountered: