Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 6 translation #13

Closed
4 tasks done
tomandersen opened this issue Dec 2, 2019 · 4 comments
Closed
4 tasks done

Laravel 6 translation #13

tomandersen opened this issue Dec 2, 2019 · 4 comments

Comments

@tomandersen
Copy link

tomandersen commented Dec 2, 2019

Prerequisites

Please answer the following questions for yourself before submitting an issue.

  • I am running the latest version
  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed
  • I'm reporting the issue to the correct repository (for multi-repository projects)

Expected Behavior

{{ __('Validation') }} and {{ __('validation') }} will return the string 'Validation' - in validation.blade.php line 10

Current Behavior

The translation system sees the word 'validation' and loads the entire file validation.php from the en lang resources, which is not right.

Failure Information (for bugs)

ErrorException (E_ERROR)
htmlspecialchars() expects parameter 1 to be string, array given (View: /Users/tandersen/code/aotc-app/resources/views/pages/validation.blade.php)

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

install argon
composer install
Laravel 6
Visit 'Validation' from the left side bar
Crashes

Context

Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

Context
macOS 10.14.6
Chrome

Failure Logs

Please include any relevant log snippets or files here.

@tomandersen
Copy link
Author

Expected Behavior
{{ __('Validation') }} and {{ __('validation') }} will return the string 'Validation' - in validation.blade.php line 10

Current Behavior
The translation system sees the word 'validation' and loads the entire file validation.php from the en lang resources, which is not right.

Failure Information (for bugs)
ErrorException (E_ERROR)
htmlspecialchars() expects parameter 1 to be string, array given (View: /Users/tandersen/code/aotc-app/resources/views/pages/validation.blade.php)
Previous exceptions

Steps to Reproduce
Please provide detailed steps for reproducing the issue.

install argon
composer install
Laravel 6
Visit 'Validation' from the left side bar
Crashes

Context
macOS 10.14.6
Chrome

NOTES:
Changing the string to anything other than 'validation' works.

I think that the project should switch to using en.json instead of old php translation files.

Screen Shot 2019-12-02 at 9 48 22 AM

@tomandersen
Copy link
Author

IF you can't reproduce, please change line 10 in validation.blade.php to __('validation') with lower case to see the issue.

@tomandersen
Copy link
Author

the project should switch to using en.json instead of old php translation files.

@teamupdivision
Copy link
Collaborator

Hello @tomandersen. Thank you for using our products.
We've made the necessary fixes, please check them out by downloading the archive again from your downloads section.

Best
Eugen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants