Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] 'Default Brand Text' appears as the view title for dynamic routes #272

Closed
ShariqKhan2012 opened this issue Sep 25, 2021 · 4 comments
Closed

Comments

@ShariqKhan2012
Copy link

Version

1.10.0

Reproduction link

http://localhost:3000

Operating System

Ubuntu 18.04

Device

Lenevo Ideapad

Browser & Version

Chrome 93.0.4577.63

Steps to reproduce

  1. Add a route in route.js:
    ...
    {
    path: "/profile/:id",
    name: "Edit Profile",
    mini: "EP",
    component: EditProfile,
    layout: "/admin",
    invisible: true,
    },
    ...

  2. Go to the /profile/2 page

What is expected?

I would expect the view title to come out as 'Edit Profile'

What is actually happening?

The route works fine and all, but the view title comes out as 'Default Brand Text'


Solution

Additional comments

I don't have a publicly accessible link as of now, so I put localhost in the field there.
However, you can verify it in any setup.

The relevant code is in the function getActiveRoutes in the file /src/layouts/Admin.js

This line to be specific:
if (window.location.href.indexOf(routes[i].layout + routes[i].path) !== -1) {
return routes[i].name;
}

Since the href is like "/profile/2" , the above condition is not satisfied, and hence the default text is displayed

@ShariqKhan2012
Copy link
Author

Anyone looking into this?

@ShariqKhan2012
Copy link
Author

Is there a special process one has to go through to get someone to look at a bug report?
It's been 10 days since I opened this, and nobody has responded till now.

@ShariqKhan2012
Copy link
Author

It is hard to believe that nobody has responded to this issue till now.
ts not about the solution (I have created a workaround myself), but about the utter lack of response from the dev team.
And to think that I am a paying customer who has paid for this template.
This does not inspire much confidence when and if I come across more complex bugs.
Have to say I am extremely disappointed.

@sajadevo
Copy link
Contributor

sajadevo commented Dec 7, 2021

**Hi @ShariqKhan2012 **

Sorry for the late response we have just updated the product and now its fine if you still need support just write me there.

All the best
Sajad

@sajadevo sajadevo closed this as completed Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants