Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.2.0] missing "components/CustomButtons/IconButton.jsx" #16

Closed
haysclark opened this issue Oct 15, 2018 · 3 comments
Closed

[1.2.0] missing "components/CustomButtons/IconButton.jsx" #16

haysclark opened this issue Oct 15, 2018 · 3 comments
Labels
bug Something isn't working

Comments

@haysclark
Copy link

haysclark commented Oct 15, 2018

Missing file

In the docs for header the "Navbar with notifications" references IconButton and imports the expected files: import IconButton from "components/CustomButtons/IconButton.jsx";. Unfortunetly, the CustomButtons/IconButton.jsx component is not included with the package, I only see "components/CustomButtons/Button.jsx".

Using Material-UI's Icon Button does not work either. :(

The sample code

From demos.creative-tim.com/material-kit-pro-react/#/documentation/header

import React from "react";

// @material-ui/core components
import withStyles from "@material-ui/core/styles/withStyles";
import List from "@material-ui/core/List";
import ListItem from "@material-ui/core/ListItem";
// @material-ui/icons
import Search from "@material-ui/icons/Search";
import Email from "@material-ui/icons/Email";
import Face from "@material-ui/icons/Face";
import Settings from "@material-ui/icons/Settings";
import AccountCircle from "@material-ui/icons/AccountCircle";
import Explore from "@material-ui/icons/Explore";
// core components
import GridContainer from "components/Grid/GridContainer.jsx";
import GridItem from "components/Grid/GridItem.jsx";
import Header from "components/Header/Header.jsx";
import CustomInput from "components/CustomInput/CustomInput.jsx";
import IconButton from "components/CustomButtons/IconButton.jsx";
import CustomDropdown from "components/CustomDropdown/CustomDropdown.jsx";
import Button from "components/CustomButtons/Button.jsx";

import navbarsStyle from "assets/jss/material-kit-pro-react/views/componentsSections/navbarsStyle.jsx";

import image from "assets/img/bg.jpg";
import profileImage from "assets/img/faces/avatar.jpg";

// ...

<Header
            brand="Navbar with notifications"
            color="dark"
            links={
              <List className={classes.list + " " + classes.mlAuto}>
                <ListItem className={classes.listItem}>
                  <Button
                    href="#pablo"
                    className={classes.navLink}
                    onClick={e => e.preventDefault()}
                    color="transparent"
                  >
                    Discover
                  </Button>
                </ListItem>
                <ListItem className={classes.listItem}>
                  <Button
                    href="#pablo"
                    className={classes.navLink}
                    onClick={e => e.preventDefault()}
                    color="transparent"
                  >
                    Wishlist
                  </Button>
                </ListItem>
                <ListItem className={classes.listItem}>
                  <IconButton
                    href="#pablo"
                    className={classes.notificationNavLink}
                    onClick={e => e.preventDefault()}
                    color="rose"
                  >
                    <Email />
                  </IconButton>
                </ListItem>
                <ListItem className={classes.listItem}>
                  <CustomDropdown
                    left
                    caret={false}
                    hoverColor="black"
                    dropdownHeader="Dropdown Header"
                    buttonText={
                      <img
                        src={profileImage}
                        className={classes.img}
                        alt="profile"
                      />
                    }
                    buttonProps={{
                      className:
                        classes.navLink + " " + classes.imageDropdownButton,
                      color: "transparent"
                    }}
                    dropdownList={[
                      "Me",
                      "Settings and other stuff",
                      "Sign out"
                    ]}
                  />
                </ListItem>
              </List>
            }
          />
@einazare einazare added the bug Something isn't working label Oct 15, 2018
@einazare
Copy link
Contributor

Hello there @haysclark ,

Thank you for showing us this issue.
I am going to change this by the end of this day.

Best,
Manu

@haysclark
Copy link
Author

@einazare This issue has been closed, yet I don't see any updates, no links to a new version or even the missing code snippet. Shouldn't these issues remain Open until they are resolved?

@einazare
Copy link
Contributor

einazare commented Oct 16, 2018

Hello again @haysclark ,

I've made the changes on the header docs. If you navigate there, everything should be fine now. If not, please refresh a few times, the page might be cached, and that is why you would not see the changes.

Best,
Manu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants