Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Bumpy install process; not geared for windows machines #25

Closed
SeanKilleen opened this issue Apr 23, 2022 · 2 comments
Closed

[Bug] Bumpy install process; not geared for windows machines #25

SeanKilleen opened this issue Apr 23, 2022 · 2 comments

Comments

@SeanKilleen
Copy link

SeanKilleen commented Apr 23, 2022

Version

1.2.0

Reproduction link

It's the out of the box ZIP file.

Operating System

Windows 11

Device

Dell XPS 15

Browser & Version

N/A

Steps to reproduce

  • Download the ZIP file of the theme
  • Extract zip file into a folder
  • Run npm install:clean or npm install

What is expected?

Things are installed and I can run the app

What is actually happening?

npm install:clean fails on windows because it uses the rm -rf command which is not a valid command on windows. npm install fails because of an issue with gyp installing node-sass. Updating the version of node-sass from v5 to v6 appears to break a rule somewhere and then fails for that reason.


Solution

For the issue with install:clean, you may want to create a separate command for windows users that uses a natively available command; alternately, I think some projects previously made use of the rimraf package for this, though my memory is shaky there.

Additional comments

Surprised to see how out of date some of the libraries are in the theme. I'd expect a purchased product to be using the latest libraries for a fresh start, not versions from a year ago; or at least kept up with the latest bugfix/patch releases. Was hoping to use this product to give myself a jump start; instead I had to spend time trying to fix it.

@sajadevo
Copy link
Collaborator

Hi @SeanKilleen

Thanks for using our product, the npm install:clean is not working its only for the linux based machines and related to the next issue please run the following commands in order to fix it:

  1. Uninstall node-sass: npm un node-sass
  2. Install sass: npm i sass
  3. On the package.json replace all the node-sass commands with sass.

Note: To get the latest updates and supports for the products and other related things to Creative Tim please join our Discord Community.

All the best,
Sajad

React Developer @ Creative-Tim.com

@sajadevo
Copy link
Collaborator

The issue is fixed for the new version of the product (v1.2.1) please update to the latest version to get the fixed version of the product.

Regards,
Sajad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants