Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Scrolling in pages, such as login, lock, register (again) #33

Closed
OdiljonQurbon opened this issue Feb 4, 2020 · 8 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@OdiljonQurbon
Copy link

Version

Version 2.1.0

Reproduction link

https://demos.creative-tim.com/vuetify-material-dashboard-pro/

Operating System

Windows 10

Device

PC

Browser & Version

Firefox 70, Chrome 76

Steps to reproduce

Just navigate to login pages

What is expected?

All links and elements are in the page without scrolling

What is actually happening?

the page is not fitting the screen in terms of height, I should scroll down to see the footer


Solution

Additional comments

This issue was in v1.0.0 and fixed in 1.0.1. Now it back again.
image

@phillipa-llama
Copy link

I noticed this as well and presumed it was part of the fix for #20 in v2.1.0
I think the issue is being cause by the v-responsive__sizer adding additional padding to the bottom of the screen, because when I remove it it works perfectly, but can't find where it is being generated from:

image

@nonoodles
Copy link

Same issue with the update, its on the CT demo site as well.

@johnleider
Copy link

Looking into it.

@johnleider johnleider self-assigned this Feb 8, 2020
@johnleider
Copy link

Can you upgrade to the latest Vuetify version (v2.2.11) and see if the issue persists?

@phillipa-llama
Copy link

@johnleider I have tested with Vuetify v2.2.11 (previously we were using v2.2.8) this morning and the issue still persists. The only way I can get our login screen to load on Desktop with no scrolling is to remove the v-responsive__sizer div in Chrome tools after it has loaded.

Let me know if you require screenshots/recording.

@johnleider
Copy link

I'm still having issues reproducing this. Need more precise steps. A video may help, but keep in mind additional info will probably be needed. Thank you!

@nonoodles
Copy link

I'm still having issues reproducing this. Need more precise steps. A video may help, but keep in mind additional info will probably be needed. Thank you!

@johnleider - Reproduction is easy. @OdiljonQurbon gave an accurate account of what the problem is I am not sure what you are struggling with.

navigate to : https://www.creative-tim.com/product/vuetify-material-dashboard-pro

Click on "Live Preview"

Navigate to the login page template. You will notice the scrollbar on the right, and the footer placed well below the bottom of the page instead of adjusting the element to the height of the page.

creativetim

I have this morning again downloaded a clean copy of the dashboard from creative tim. The issue persists even with vuetify 2.2.25.

@johnleider
Copy link

Resolved. Will be out with next release.

@johnleider johnleider added bug Something isn't working and removed needs more information labels May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants