[none] refactoring: 읽기 편하게 구조 개선, 소소한 기능 추가 #7
Conversation
Coverage report
Show new covered files 🐣
Test suite run success5 tests passing in 5 suites. Report generated by 🧪jest coverage report action from 9a9b23a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다~
@@ -1,11 +1,11 @@ | |||
{ | |||
"name": "@creatrip/env-safe", | |||
"version": "0.1.4", | |||
"version": "0.2.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
리팩토링으로 인해 로직이 많이 바뀌었고, 신규 기능도 추가되었기 때문에 0.2.0
으로 마이너 버전을 올렸습니당.
"description": "🔑 Loads environment variables from .env for nodejs projects with safe", | ||
"main": "index.js", | ||
"types": "index.d.js", | ||
"scripts": { | ||
"build": "tsc", | ||
"build": "tsc -p ./tsconfig.build.json", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
빌드용 json 파일을 따로 만들어서 관리를 하는게 좋은 것 같습니당.
예:
- tsconfig.json → IDE에서 사용, test 코드 포함
- tsconfig.build.json → 빌드에서만 사용, test 코드 제외
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다~~
작업 내용
구조 개선
소소한 기능 추가
2022-12-02.6.07.25.mov