Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard on type-in number settings shows a comma, can't type a period #27

Closed
Vermoot opened this issue Dec 14, 2017 · 3 comments
Closed

Comments

@Vermoot
Copy link

Vermoot commented Dec 14, 2017

My phone's main language is French, and I suppose it might be why the number keypad on "Corner Radius", "Vertical Adjustment", etc settings shows a comma (as we use commas for decimal points in french) instead of a period, and the tweak doesn't understand "0,3" as a valid corner radius as opposed to "0.3".

I guess you could either force the keypad to have a period instead of a comma on relevant languages, or make the tweak understand commas as a decimal point.

@CreatureSurvive
Copy link
Owner

Hmm, I was not aware that some languages use commas rather than periods for decimals. Unfortunately IOS doesn't really offer any official way of dealing with this issue, and we can't modify the keyboard either. So I'll fix this by adding support for comma separated decimals in my preference library. That way users who are accustom to using commas can continue to do so. I'll hopefully have this fixed today.

@Vermoot
Copy link
Author

Vermoot commented Dec 16, 2017

Awesome, thank you!

@CreatureSurvive
Copy link
Owner

@Rougemoot so I wasn't able to go through with the fix I had mentioned earlier, I ran into some issues with that approach. However, I have implemented a solution, for languages that use a character other than . they will get a regular number keypad with no decimal, then I've added a period to the toolbar that they can use.
img_0558

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants