Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible SQL Injection? #2

Closed
neovintage opened this issue Nov 29, 2016 · 2 comments · Fixed by #8
Closed

Possible SQL Injection? #2

neovintage opened this issue Nov 29, 2016 · 2 comments · Fixed by #8

Comments

@neovintage
Copy link
Contributor

Was looking through the SQL generation code and I couldn't tell. Are the parameters getting sanitized before building the query?
@fridgerator
Copy link
Member

I was actually just looking at this today, currently I'm not doing anything. However it should be a priority.

crystal-pg appears to have some method to sanitize parameters, but only if you used parameterized queries (which is not being used).

@fridgerator
Copy link
Member

Moving towards parameterized queries, should have a fix in later today.

@fridgerator fridgerator mentioned this issue Dec 1, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Parameterized queries Crecto/crecto
2 participants
@neovintage @fridgerator