Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looking for Maintainers! #228

Open
sadortun opened this issue Jul 10, 2024 · 3 comments
Open

Looking for Maintainers! #228

sadortun opened this issue Jul 10, 2024 · 3 comments

Comments

@sadortun
Copy link
Member

We would love if you are using this project or can test a PR to contact us bellow or review the PRs so we can merge them.

I personally no longer have a test setup to validate the PRs so I'm a bit reluctant to merge code without some prior validation.

Many people still use this project https://packagist.org/packages/creof/doctrine2-spatial/stats , I'm not sure archiving it would be beneficial overall to the community.

Your help is most welcome!

You can Tag me in any PR that you review when they are ready to be merged.

@PowerKiKi
Copy link
Contributor

The maintainer you are looking for already exists, it is @Alexandre-T. He already did a lot of work, in #209, that was never merged. Meanwhile he created a fork and has been maintaining it for the past 3 years.

In fact, it will soon become more popular than creof/doctrine2-spatial:

image

Instead of trying to revive this project, and splitting the community in two forever, I think it would be wiser (and much easier) to redirect this half of the community to his fork. Don't you think ?

@sadortun
Copy link
Member Author

Alright @Alexandre-T is a hero! 😎

I remember the issue was about potential BC break between 5.3 and 7.1.

That's really unfortunate.

@ddproxy @djlambert any input?

@Alexandre-T
Copy link

Thank you @PowerKiKi for your words, thank you @sadortun and @djlambert for your work.

I've ensured compatibility with PHP 8.1+ and all upcoming major versions of doctrine/orm. I've also forked the three parsers: geo-parser, wkt-parser, and wkb-parser. Additionally, I've created comprehensive documentation using Sphinx and hosted it on Read the Docs. To streamline the development process for maintainers, developers, and contributors, I've implemented a one-command setup for a full development stack using docker-compose up -d. Furthermore, the project utilizes GitHub Actions for continuous integration, automatically testing each pull request before merging.

We currently working to be compliant with MariaDB and MSSQL Server.

I read that creof/doctrine-spatial repository is now marked as abandoned.
I suggest you to update the four composer.json files to add the below line. So, packagist.org will be automatically updated and developers using your library can immediately find a solution on our repositories. If anyone want to help, you're all very welcomed.

    "abandoned": "longitude-one/doctrine-spatial",
    "abandoned": "longitude-one/wkb-parser",
    "abandoned": "longitude-one/wkt-parser",
    "abandoned": "longitude-one/geo-parser",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants