Fixed rust examples #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rust 1.29 brings stable allocator API. Outdated API removed from the rust stdlib. I still can't compile "rust-regex" due to "Error in command 'compile': Method code too large!"
|
Thanks! Will review in the next couple of days.
Yeah, some runtimes are making really large WASM functions which exceed the JVM method size limit. I started work on this in #19 but I think I will have to change tack. I had an algorithm that tried to do an intelligent de-dupe, but I think now I'm just gonna break the method in half. |
|
ping |
|
Sorry, been busy. I did complete #19 a couple weeks ago. Will update when I've worked with and tested this. |
|
Merged into master, but I have not done any tests yet. Doing now. |
|
I am still working through this (finding bugs in my method splitter). Could take some time. |
cretz
added a commit
that referenced
this pull request
Oct 4, 2018
|
Ok, this should now be fixed in master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust 1.29 brings stable allocator API.
Outdated API removed from the rust stdlib.
I still can't compile "rust-regex" due to
"Error in command 'compile': Method code too large!"