Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo crev review <crate> should error on version ambiguity #29

Closed
dpc opened this issue Dec 3, 2018 · 0 comments
Closed

cargo crev review <crate> should error on version ambiguity #29

dpc opened this issue Dec 3, 2018 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers
Milestone
cargo-crev 0.5

Comments

@dpc
Copy link
Collaborator

dpc commented Dec 3, 2018 •
edited

If the project is using multiple versions of same <crate>, the <version> argument must be passed to specify which.

Right now it will create a proof for the "random" one.
@dpc dpc added this to the 0.1 - MVP: cargo-crev/cargo-trust milestone Dec 3, 2018
@dpc dpc added the good first issue Good for newcomers label Dec 3, 2018
@dpc dpc changed the title cargo crev trust <crate> should error on version mismatch cargo crev trust <crate> should error on version ambiguity Dec 3, 2018
@dpc dpc added the bug Something isn't working label Dec 3, 2018
@dpc dpc changed the title cargo crev trust <crate> should error on version ambiguity cargo crev review <crate> should error on version ambiguity Dec 3, 2018
@dpc dpc closed this as completed in 042f284 Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
cargo-crev 0.5
Development

No branches or pull requests
1 participant
@dpc