Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trex delete doesnt delete all the packages in import_map.json #137

Open
Atticus64 opened this issue Jan 23, 2023 · 4 comments
Open

trex delete doesnt delete all the packages in import_map.json #137

Atticus64 opened this issue Jan 23, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@Atticus64
Copy link

Atticus64 commented Jan 23, 2023

Describe the bug

When i run from powershell trex delete doesnt delete the package from import_map.json file

To Reproduce Steps to reproduce the behavior:

  1. Run in powershell trex delete some_package

Screenshots
bug

Desktop

  • OS: Windows 10
  • Deno version: 1.12.1
  • Trex Version 1.29.4

Some times works but with some specific packages dont work

@Atticus64 Atticus64 changed the title trex delete doesnt delete the package in import_map.json trex delete doesnt delete all the packages in import_map.json Jan 23, 2023
@Atticus64
Copy link
Author

maybe the problem is the name of import is custom, idk

@ghaerdi ghaerdi added the bug Something isn't working label Jan 23, 2023
@Atticus64
Copy link
Author

Atticus64 commented Jan 23, 2023

@ghaerdi do you want to close this issue?

@ghaerdi
Copy link
Member

ghaerdi commented Jan 23, 2023

I will leave this issue open until the fix is released in the next trex version (probably 1.12.2 or 1.13.0). I want to add some unit testing ASAP before releasing it.
The fix is available in the canary version, you can switch to it using the next command:

trex upgrade --canary

@Atticus64
Copy link
Author

Oh thanks @ghaerdi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants