Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL parameter values being stripped in import_map.json with trex --custom #97

Closed
sramam opened this issue Jun 22, 2021 · 2 comments
Closed

URL parameter values being stripped in import_map.json with trex --custom #97

sramam opened this issue Jun 22, 2021 · 2 comments
Assignees
@buttercubz
Labels
bug Something isn't working

Comments

@sramam
Copy link

sramam commented Jun 22, 2021 

trex --custom ts-json-schema-generator=https://esm.sh/ts-json-schema-generator?target=deno

is converted to

{
  "imports": {
    "ts-json-schema-generator": "https://esm.sh/ts-json-schema-generator?target"
   }
}

Note the stripping of the URL parameter value.
@buttercubz buttercubz self-assigned this Jun 22, 2021
@buttercubz buttercubz added the bug Something isn't working label Jun 22, 2021
buttercubz added a commit that referenced this issue Jun 22, 2021
@buttercubz
fix: URL parameter values being stripped #97
e83aa1d
@buttercubz
Copy link
Member

also this bug is fixed in dev branch

@sramam
Copy link
Author

sramam commented Jun 23, 2021

Also verified. Thanks much for the quick resolutions

@sramam sramam closed this as completed Jun 23, 2021
buttercubz added a commit that referenced this issue Jul 2, 2021
@buttercubz @michael-spengler
@RivierGrullon @jollytoad
trex v1.8.0 (#96)
b28d190 
* feat: better main file detection

* fix: import typo

* fix: test on macos

* feat: virtual cli tool execution

* fix: add default error message in exec command

* chore: update std to std@0.99.0

* chore: upgrade ci version

* fix: test

* Update run.ts (#95)

* Update run.ts

Co-authored-by: Rivier Grullon <45011060+RivierGrullon@users.noreply.github.com>
Co-authored-by: Erick Sosa <ericksosagarcias@gmail.com>
Co-authored-by: Mark Gibson <mgibson@adaptavist.com>

* fix: URL parameter values being stripped #97

* fix: does not install if absolute path mappings are specified #98

* chore: update cli version

Co-authored-by: michael spengler <43786652+michael-spengler@users.noreply.github.com>
Co-authored-by: Rivier Grullon <45011060+RivierGrullon@users.noreply.github.com>
Co-authored-by: Mark Gibson <mgibson@adaptavist.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@buttercubz buttercubz

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sramam @buttercubz