Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[meta] PR's over direct commits #48

Closed
FreekingDean opened this issue Feb 23, 2017 · 5 comments
Closed

[meta] PR's over direct commits #48

FreekingDean opened this issue Feb 23, 2017 · 5 comments

Comments

@FreekingDean
Copy link

Hey! This is a super meta thing, but since Go packages are assumed stable at the master branch can we set this repo to not allow direct commits to master, and only allow PR's 馃槃

This allows the community to code review and verify awesomeness of additional features.

Thanks!

@FreekingDean
Copy link
Author

Also, because I'm not sure if everyone is aware, there are settings in the repository settings area that allow for this!

@FreekingDean
Copy link
Author

Just to add I know
1baa789
was a bug, but I was more so referring to
8f75fbd

@crewjam
Copy link
Owner

crewjam commented Mar 2, 2017

I'm not opposed to it in theory, but perhaps a better approach, now that people are using it a bit, would be to have proper versions. Thoughts?

@FreekingDean
Copy link
Author

I think that is also good. I have just always heard that master is supposed to be a stable head. So possibly versioning & a dev branch?

@crewjam
Copy link
Owner

crewjam commented Apr 23, 2017

I've tagged a version 0.1.0 and intend to create more tags at major release points.

@crewjam crewjam closed this as completed Apr 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants