Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Specify prettier version #9

Closed
akgoogle opened this issue Mar 23, 2020 · 4 comments · Fixed by #11
Closed

[FEATURE] Specify prettier version #9

akgoogle opened this issue Mar 23, 2020 · 4 comments · Fixed by #11
Assignees
@creyD
Labels
enhancement New feature or request

Comments

@akgoogle
Copy link

What would you like to change about the program?
A way to specify the prettier version number.

Why do you think this is a cool idea?
Some node versions don't support prettier v2.x.x. I'd like to use this action with prettier v1.19.1
@akgoogle akgoogle added the enhancement New feature or request label Mar 23, 2020
@creyD
Copy link
Owner

creyD commented Mar 23, 2020

Good idea! I implemented a test version in a new branch, will test tomorrow!

@creyD creyD self-assigned this Mar 23, 2020
@creyD creyD mentioned this issue Mar 24, 2020
Merged
@creyD
Copy link
Owner

creyD commented Mar 24, 2020

I implemented it for now, you may test it and I would appreciate feedback!

@creyD creyD closed this as completed Mar 24, 2020
@akgoogle
Copy link
Author

Yeah, after upgrading to v2.2 of your action and specifying prettier_version, it works as intended. Thanks!

        uses: creyD/prettier_action@v2.2
        with:
          prettier_version: "1.19.1"

@creyD
Copy link
Owner

creyD commented Mar 24, 2020

Great! :)

@creyD creyD linked a pull request Mar 29, 2020 that will close this issue
Added npm Version Selection #11
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@creyD creyD

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added npm Version Selection creyD/prettier_action
2 participants
@creyD @akgoogle