Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix check for rw mounts test #3662

Closed
haircommander opened this issue Apr 24, 2020 · 1 comment · Fixed by #4253
Closed

fix check for rw mounts test #3662

haircommander opened this issue Apr 24, 2020 · 1 comment · Fixed by #4253

Comments

@haircommander
Copy link
Member

sometime today, the test privileged ctr -- check for rw mounts started failing in integration_{fedora,rhel} because /sys/fs/cgroup was not mounted ro by runc. Oddly, the test is named "check for rw mounts", but switching the grep line to rw makes it fail with crun.

instead of tracking down the source of the issue, I've made the test nearly no-op, by just catting /proc/mounts here

We should determine what is expected by that test, and figure out which runtime is wrong.

@kolyshkin
Copy link
Collaborator

Alas, the test itself is wrong. It is supposed to run a privileged container, and commit d3a50d8 (PR #2627) even adds the test/testdata/container_config_privileged.json file, but it is not used by the test.

I am looking into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants