Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make use of c/storage Check() and Repair() functions #7177

Closed
haircommander opened this issue Jul 27, 2023 · 4 comments · Fixed by #7190
Closed

make use of c/storage Check() and Repair() functions #7177

haircommander opened this issue Jul 27, 2023 · 4 comments · Fixed by #7190
Assignees
Milestone

Comments

@haircommander
Copy link
Member

currently, crio wipe checks if the node improperly shut down, and if so just removes the whole image store. this is a very heavy hammer. in containers/storage#1569 @nalind added the abiliity to do consistency checks and repair the OS. We should update crio wipe to utilize them instead of removing the directory.

@haircommander haircommander added this to the 1.28 milestone Jul 27, 2023
@haircommander
Copy link
Member Author

setting an optimistic 1.28 for this--it would be great to get this in by then

@MdSahil-oss
Copy link
Contributor

@haircommander I would like to work on this :)

@nalind
Copy link
Collaborator

nalind commented Aug 1, 2023

currently, crio wipe checks if the node improperly shut down, and if so just removes the whole image store. this is a very heavy hammer. in containers/storage#1569 @nalind added the abiliity to do consistency checks and repair the OS.

I need to be clear about expectations here - there isn't enough redundancy in how we store layer contents to be able to reliably repair images when we detect that some of their contents have been modified or removed: in most if not all cases, the repair logic is still going to remove what there is left of the image, with the expectation that it will be pulled again.

@haircommander
Copy link
Member Author

that's perfect! that vastly improves from our current situation of just removing the whole c/storage if we detect an unclean shutdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants