Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix#16 #31

Closed
wants to merge 3 commits into from
Closed

Fix#16 #31

wants to merge 3 commits into from

Conversation

blogpranav
Copy link

Description

Renaming the file config.js according to the standard. Changed the filename to util.js

Fixes #16

Type of Change:

Change in filename.

  • Bug fix (non-breaking change which fixes an issue)

@welcome
Copy link

welcome bot commented Apr 11, 2020

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

- fix: don't overwrite prevent_default if default wasn't prevented

- feat: add app.isPackaged() method

- docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

- Follow the JavaScript, C++, and Python coding style.

- Run npm run lint locally to catch formatting errors earlier.

- Document any user-facing changes you've made following the documentation styleguide.

- Include tests when adding/changing behavior.

- Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@rsarky
Copy link
Member

rsarky commented Apr 13, 2020

LGTM, can you squash your commits and follow the Semantic Commit messages guidelines too?
You can read about git rebase to achieve thiss.
Tell me if you need help

@blogpranav
Copy link
Author

Should I make another PR? Can you please elaborate a lil bit?

@rsarky
Copy link
Member

rsarky commented Apr 16, 2020

Sure!
So normally we want to have one commit per feature. It keeps the git history clean.
So what we need to do is squash the 3 commits that you have, into one.

Essentially you need to use the git rebase command to squash these commits. There are other ways but I find this the easiest.
So in your feature branch you can run git rebase -i HEAD~3. You can then change the pick keywords in each line to squash.
Once you save that you will be prompted to update your commit message.
As the bot mentioned above we use something called as semantic commit messages. It is essentially a guideline to format your commit messages. Again this makes your git history neater and easier to go through.
So for this change you can have something like: chore: change filename from xyz to abc

You can google or ask here if you have any issues!

@blogpranav blogpranav closed this Apr 20, 2020
@rsarky rsarky reopened this Apr 20, 2020
@rsarky
Copy link
Member

rsarky commented Apr 20, 2020

Hey, you neednt close this PR. You can make the changes in the same one

@blogpranav
Copy link
Author

ok i'll do it. thanks for the help

@blogpranav
Copy link
Author

Can I just close this PR and create a new one with all the required changes? It's a bit confusing for me as I'm new to git.

@rsarky
Copy link
Member

rsarky commented Apr 20, 2020 via email

@blogpranav blogpranav closed this Apr 23, 2020
@blogpranav blogpranav deleted the fix#16 branch April 23, 2020 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename filename config.js
2 participants