Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: additional capital of the emoji #9

Closed
hiberabyss opened this issue Nov 28, 2017 · 12 comments
Closed

Bug: additional capital of the emoji #9

hiberabyss opened this issue Nov 28, 2017 · 12 comments

Comments

@hiberabyss
Copy link

After install this plugin, and input :sparkles: in my blog. There will be capital with emoji like following image:

image

My configurations:

githubEmojis:
  enable: true
  className: github-emoji
  unicode: false
  styles:
    display: inline
    vertical-align: bottom
  localEmojis:
@crimx
Copy link
Owner

crimx commented Nov 28, 2017

Can you paste the generated html source code?

@hiberabyss
Copy link
Author

hiberabyss commented Nov 28, 2017

Here are the codes got via chrome inspect:

<a href="https://assets-cdn.github.com/images/icons/emoji/unicode/2728.png?v7" title="sparkles" class="fancybox" rel="article"><img class="github-emoji" style="display:inline;vertical-align:bottom" title="sparkles" alt="sparkles" src="https://assets-cdn.github.com/images/icons/emoji/unicode/2728.png?v7" height="20" width="20"></a>
<span class="caption">sparkles</span>

Strange thing is that there is no caption when view the page source code.

Thanks!

@crimx
Copy link
Owner

crimx commented Nov 28, 2017

This seems like other plugins problem

@crimx
Copy link
Owner

crimx commented Nov 28, 2017

This plugin doesn't generate caption classes

@hiberabyss
Copy link
Author

It should not caused by other plugins, since Safari also have the same problem while there is no plugin installed.

@crimx
Copy link
Owner

crimx commented Nov 28, 2017

I mean hexo plugin

@crimx
Copy link
Owner

crimx commented Nov 28, 2017

Looks like you've used a hexo plugin that would generate captions for imgs

@hiberabyss
Copy link
Author

OK, I will check my hexo plugins.

Thanks!

@crimx
Copy link
Owner

crimx commented Nov 28, 2017

If you still can't find out what's going on, here is a quick fix. Add this to you page

<style>
.github-emoji + .caption {
  display: none !important;
}
</style>

@hiberabyss
Copy link
Author

Got it!

Really thanks your help!

@crimx
Copy link
Owner

crimx commented Nov 28, 2017

❤️

@newdee
Copy link

newdee commented Dec 4, 2017

it because of the fancybox, refer to #10, you can solve it.

@crimx crimx closed this as completed Jan 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants