Manifest v3 migration

[Mikescops]

As proposed in #22 here is a pull request to support the new manifest v3.

A few considerations:

• the update is a breaking change with v2
• the background script is now a service worker and should be placed at the root of the extension. As per this thread I used the importScripts() method to reuse most of the existing implementation.

Work left to do:

• I didn't update the tests for the snapshot, I'm not used to this system.
• Make sure the livereload is still working
• Add some documentation for people migrating to v3 with neutrino-webextension

[crimx]

Thanks for the input!

the update is a breaking change with v2

Can this be done intelligently? Like switching to different implementation base on the manifest_version field.

[Mikescops]

I think we can do so yes, let's try.

[Mikescops]

How do you like something like this? ⬆️

[Mikescops]

Considering that Firefox may not be compatible with v3 anytime soon, I recommend adding an explanation to have 2 different .neutrinorc.js configuration with different manifest so that it's easy to build for v2 and v3 in a same project.

Like specified here: https://neutrinojs.org/usage/#generating-multiple-builds

[crimx]

The implementation looks so cool! Can you just copy everything inside test/ to test/manifestV3/ and make changes there instead? I'll take care of the rest.

[Mikescops]

The implementation looks so cool! Can you just copy everything inside test/ to test/manifestV3/ and make changes there instead? I'll take care of the rest.

I'd recommend not having a /test folder and using the branch system to separate the new version 👍

let say:

• until release masterbranch is the current v2 and beta branch is the v3+v2
• after release v2 branch will be the v2 and master branch will be v3+v2

that way we don't add noise to the repository and we can backport any potential hotfix of the v2

also when publishing the package you can set the beta branch to beta on npm

[crimx]

I was going to do something like

/test/
  manifestV2/
  manifestV3/

so that I can test both of them. What's the downside of this approach?

[Mikescops]

Ah sorry, only for the tests, ok, I misunderstood, i thought you wanted to duplicate the whole code, in a subfolder for the v3

[Mikescops]

Took me a while but I finally figured out how to build two presets at the same time.
So now:

• tests are in separate folder
• it's possible to build v2 and v3 at the same time with different configurations (for Firefox in v2 on one side and Chrome in v3 on the other for instance)

[crimx]

LGTM! Thanks for the PR!