Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update WebExtHot.runtime.js #6

Merged
merged 1 commit into from Nov 3, 2020
Merged

Update WebExtHot.runtime.js #6

merged 1 commit into from Nov 3, 2020

Conversation

Jack-Works
Copy link
Member

No description provided.

@Jack-Works
Copy link
Member Author

If script-src: unsafe-eval is not set in dev mode, HMR will fail because eval error

@crimx crimx merged commit f849790 into awesome-webextension:master Nov 3, 2020
@Jack-Works Jack-Works deleted the patch-1 branch November 3, 2020 07:17
@crimx
Copy link
Member

crimx commented Nov 3, 2020

Thanks for the PR! LGTM. Should I publish now?

@Jack-Works
Copy link
Member Author

No hurry, thank you

@crimx
Copy link
Member

crimx commented Nov 3, 2020

I meant is it good to go? Do you have more PRs? I can wait if you want to.

@Jack-Works
Copy link
Member Author

No more changes currently.. It's working well in our environment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crimx crimx crimx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jack-Works @crimx