Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In tests use ergo from $PATH than relative path. #24

Closed
sitaramshelke opened this issue Oct 1, 2017 · 5 comments
Closed

In tests use ergo from $PATH than relative path. #24

sitaramshelke opened this issue Oct 1, 2017 · 5 comments

Comments

@sitaramshelke
Copy link
Contributor

While trying to understand the code, I tried to run the tests. There we are looking for ergo binary using relative path in ergo_run_test.go. Can we simply replace it ergo, since we might already have it installed in out $PATH?

@cristianoliveira
Copy link
Owner

Hey @sitaramshelke thanks for pointing that out. It seems that is a problem on the test flow indeed. We don't see that happening on travis.ci buildings cause it always build before testing. I am not sure if we can use the binary installed on current '$PATH' because we can't ensure that it has the last version.

I think these tests deserve a refactor but for now, we can basically ensure that we are building before testing. In order to ensure it we can include it into Makefile:

test: build
	@go test ./... -v

and then use make test for testing

I accept suggestions also. :)

@sitaramshelke
Copy link
Contributor Author

Ah, I did not consider CI part. Running make tasks seems good to me. IMO can we have a contribution.md with little info about the steps and tasks that need to be run?

@cristianoliveira
Copy link
Owner

Totally agree. I will open a issue for it. It should a contains step by step instruction for cloning it, building and testing.

@srini156
Copy link
Contributor

srini156 commented Oct 2, 2017

@cristianoliveira - I also encountered this issue on my local. I tried using $GOPATH/bin/ergo but didn't work for me. If you are looking for contributions, perhaps I could help again 👍

@cristianoliveira
Copy link
Owner

Hey @srini156 we already solved this problem :)
Sure, any help would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants