-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In tests use ergo
from $PATH than relative path.
#24
Comments
Hey @sitaramshelke thanks for pointing that out. It seems that is a problem on the test flow indeed. We don't see that happening on I think these tests deserve a refactor but for now, we can basically ensure that we are building before testing. In order to ensure it we can include it into Makefile: test: build
@go test ./... -v and then use I accept suggestions also. :) |
Ah, I did not consider CI part. Running make tasks seems good to me. IMO can we have a |
Totally agree. I will open a issue for it. It should a contains step by step instruction for cloning it, building and testing. |
@cristianoliveira - I also encountered this issue on my local. I tried using |
Hey @srini156 we already solved this problem :) |
While trying to understand the code, I tried to run the tests. There we are looking for
ergo
binary using relative path inergo_run_test.go
. Can we simply replace itergo
, since we might already have it installed in out $PATH?The text was updated successfully, but these errors were encountered: