Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

md5 too slow #1

Open
h2oiswater opened this issue Jun 22, 2023 · 3 comments
Open

md5 too slow #1

h2oiswater opened this issue Jun 22, 2023 · 3 comments

Comments

@h2oiswater
Copy link

h2oiswater commented Jun 22, 2023

Thanks for your work, I had backup my wechat files using your script, but it will stuck quite long when file too large, so I replaced md5 to MurmurHash, same result but faster.

import mmh3

def return_murmurhash(file):
    hash_value = mmh3.hash(file)
    return hash_value
pip install mmh3
@h2oiswater
Copy link
Author

I can submit a PR if you agree :)

@Cristina269
Copy link
Owner

I can submit a PR if you agree :)

Thanks for your suggestion! I didn't consider the speed issue when writing the script because I don't have too many large files... Thank you. Please feel free to submit a PR with your proposed changes.

@Cristina269
Copy link
Owner

I can submit a PR if you agree :)

I submitted new code to make it more readable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants