Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some sites don't use <input> elements for inputs. ("Active while in inputs" doesn't work as expected) #611

Open
knoajp opened this issue Mar 18, 2024 · 1 comment

Comments

@knoajp
Copy link

knoajp commented Mar 18, 2024

Such as Reddit.
Although Reddit does have an <input> element on its search form, it uses the <reddit-search-large> element for the actual active element.
So when I type some search keywords on the search form on Reddit, Shortkeys handle every single keystroke as "it could be assigned shortcut keys", even if all the "Active while in inputs" switches are off. And usually, I end up with a variety of unintended functions launched at once.

Maybe you can use document.activeElement.isContentEditable === true for a practical "Active while in inputs" condition.

Although on Reddit, while input caret is on the search form, document.activeElement is <reddit-search-large> and it is NOT contentEditable.

@hyshen1
Copy link

hyshen1 commented Jul 12, 2024

I second to you! The add-on doesn't work correctly on reddit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants