Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons with the same name are silently overwritten when updated from game-icons.net #145

Closed
posita opened this issue Jun 9, 2020 · 0 comments · Fixed by #146
Closed

Icons with the same name are silently overwritten when updated from game-icons.net #145

posita opened this issue Jun 9, 2020 · 0 comments · Fixed by #146

Comments

@posita
Copy link
Collaborator

posita commented Jun 9, 2020

The current implementation silently overwrites icon .png files when name clashes are present. As game-icons.net has expanded, several have emerged. As of this writing, there are:

bat.png: icons/ffffff/000000/1x1/skoll/bat.png
bat.png: icons/ffffff/000000/1x1/delapouite/bat.png
bone-knife.png: icons/ffffff/000000/1x1/lorc/bone-knife.png
bone-knife.png: icons/ffffff/000000/1x1/delapouite/bone-knife.png
book-cover.png: icons/ffffff/000000/1x1/lorc/book-cover.png
book-cover.png: icons/ffffff/000000/1x1/delapouite/book-cover.png
bowie-knife.png: icons/ffffff/000000/1x1/lorc/bowie-knife.png
bowie-knife.png: icons/ffffff/000000/1x1/skoll/bowie-knife.png
butterfly-knife.png: icons/ffffff/000000/1x1/skoll/butterfly-knife.png
butterfly-knife.png: icons/ffffff/000000/1x1/delapouite/butterfly-knife.png
castle.png: icons/ffffff/000000/1x1/lorc/castle.png
castle.png: icons/ffffff/000000/1x1/delapouite/castle.png
cauldron.png: icons/ffffff/000000/1x1/lorc/cauldron.png
cauldron.png: icons/ffffff/000000/1x1/darkzaitzev/cauldron.png
clover.png: icons/ffffff/000000/1x1/sbed/clover.png
clover.png: icons/ffffff/000000/1x1/lorc/clover.png
cobra.png: icons/ffffff/000000/1x1/skoll/cobra.png
cobra.png: icons/ffffff/000000/1x1/delapouite/cobra.png
crescent-blade.png: icons/ffffff/000000/1x1/lorc/crescent-blade.png
crescent-blade.png: icons/ffffff/000000/1x1/skoll/crescent-blade.png
cultist.png: icons/ffffff/000000/1x1/lorc/cultist.png
cultist.png: icons/ffffff/000000/1x1/skoll/cultist.png
distraction.png: icons/ffffff/000000/1x1/lorc/distraction.png
distraction.png: icons/ffffff/000000/1x1/darkzaitzev/distraction.png
dragon-head.png: icons/ffffff/000000/1x1/lorc/dragon-head.png
dragon-head.png: icons/ffffff/000000/1x1/faithtoken/dragon-head.png
drill.png: icons/ffffff/000000/1x1/lorc/drill.png
drill.png: icons/ffffff/000000/1x1/delapouite/drill.png
fairy.png: icons/ffffff/000000/1x1/lorc/fairy.png
fairy.png: icons/ffffff/000000/1x1/delapouite/fairy.png
fist.png: icons/ffffff/000000/1x1/lorc/fist.png
fist.png: icons/ffffff/000000/1x1/skoll/fist.png
gas-mask.png: icons/ffffff/000000/1x1/lorc/gas-mask.png
gas-mask.png: icons/ffffff/000000/1x1/skoll/gas-mask.png
grenade.png: icons/ffffff/000000/1x1/sbed/grenade.png
grenade.png: icons/ffffff/000000/1x1/lorc/grenade.png
hand.png: icons/ffffff/000000/1x1/sbed/hand.png
hand.png: icons/ffffff/000000/1x1/lorc/hand.png
hang-glider.png: icons/ffffff/000000/1x1/skoll/hang-glider.png
hang-glider.png: icons/ffffff/000000/1x1/delapouite/hang-glider.png
headshot.png: icons/ffffff/000000/1x1/lorc/headshot.png
headshot.png: icons/ffffff/000000/1x1/skoll/headshot.png
horse-head.png: icons/ffffff/000000/1x1/lorc/horse-head.png
horse-head.png: icons/ffffff/000000/1x1/delapouite/horse-head.png
jeep.png: icons/ffffff/000000/1x1/skoll/jeep.png
jeep.png: icons/ffffff/000000/1x1/delapouite/jeep.png
key.png: icons/ffffff/000000/1x1/sbed/key.png
key.png: icons/ffffff/000000/1x1/lorc/key.png
molecule.png: icons/ffffff/000000/1x1/lorc/molecule.png
molecule.png: icons/ffffff/000000/1x1/skoll/molecule.png
mouse.png: icons/ffffff/000000/1x1/lorc/mouse.png
mouse.png: icons/ffffff/000000/1x1/delapouite/mouse.png
mp5.png: icons/ffffff/000000/1x1/skoll/mp5.png
mp5.png: icons/ffffff/000000/1x1/delapouite/mp5.png
ram.png: icons/ffffff/000000/1x1/lorc/ram.png
ram.png: icons/ffffff/000000/1x1/darkzaitzev/ram.png
revolt.png: icons/ffffff/000000/1x1/sbed/revolt.png
revolt.png: icons/ffffff/000000/1x1/darkzaitzev/revolt.png
revolver.png: icons/ffffff/000000/1x1/skoll/revolver.png
revolver.png: icons/ffffff/000000/1x1/delapouite/revolver.png
rock.png: icons/ffffff/000000/1x1/lorc/rock.png
rock.png: icons/ffffff/000000/1x1/john-redman/rock.png
rss.png: icons/ffffff/000000/1x1/lorc/rss.png
rss.png: icons/ffffff/000000/1x1/delapouite/rss.png
scissors.png: icons/ffffff/000000/1x1/lorc/scissors.png
scissors.png: icons/ffffff/000000/1x1/john-redman/scissors.png
screw.png: icons/ffffff/000000/1x1/lorc/screw.png
screw.png: icons/ffffff/000000/1x1/delapouite/screw.png
shuriken.png: icons/ffffff/000000/1x1/lorc/shuriken.png
shuriken.png: icons/ffffff/000000/1x1/darkzaitzev/shuriken.png
smartphone.png: icons/ffffff/000000/1x1/skoll/smartphone.png
smartphone.png: icons/ffffff/000000/1x1/delapouite/smartphone.png
splash.png: icons/ffffff/000000/1x1/sbed/splash.png
splash.png: icons/ffffff/000000/1x1/lorc/splash.png
steel-claws.png: icons/ffffff/000000/1x1/lorc/steel-claws.png
steel-claws.png: icons/ffffff/000000/1x1/skoll/steel-claws.png
stiletto.png: icons/ffffff/000000/1x1/lorc/stiletto.png
stiletto.png: icons/ffffff/000000/1x1/skoll/stiletto.png
stopwatch.png: icons/ffffff/000000/1x1/lorc/stopwatch.png
stopwatch.png: icons/ffffff/000000/1x1/skoll/stopwatch.png
sunrise.png: icons/ffffff/000000/1x1/lorc/sunrise.png
sunrise.png: icons/ffffff/000000/1x1/delapouite/sunrise.png
swallow.png: icons/ffffff/000000/1x1/lorc/swallow.png
swallow.png: icons/ffffff/000000/1x1/delapouite/swallow.png
syringe.png: icons/ffffff/000000/1x1/sbed/syringe.png
syringe.png: icons/ffffff/000000/1x1/lorc/syringe.png
tombstone.png: icons/ffffff/000000/1x1/sbed/tombstone.png
tombstone.png: icons/ffffff/000000/1x1/lorc/tombstone.png
trousers.png: icons/ffffff/000000/1x1/lucasms/trousers.png
trousers.png: icons/ffffff/000000/1x1/lorc/trousers.png
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant