Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing some devDependencies in package.json #179

Closed
myyellowshoe opened this issue Jun 14, 2016 · 4 comments
Closed

Consider removing some devDependencies in package.json #179

myyellowshoe opened this issue Jun 14, 2016 · 4 comments

Comments

@myyellowshoe
Copy link

myyellowshoe commented Jun 14, 2016

I've installed handlebars as my template. But still get lots of warning messages telling me it's unable to resolve some modules. the consolidate package required by this module is giving me lots of similar messages.

Unable to resolve some modules:
"emblem" in /Users/administrator/Dropbox/Development/hubbble/hubbblewww/node_modules/email-templates/lib/template-manager.js (os.osx.x86_64)
"less" in /Users/administrator/Dropbox/Development/hubbble/hubbblewww/node_modules/email-templates/lib/template-manager.js (os.osx.x86_64)
"stylus" in /Users/administrator/Dropbox/Development/hubbble/hubbblewww/node_modules/email-templates/lib/template-manager.js (os.osx.x86_64)
"styl" in /Users/administrator/Dropbox/Development/hubbble/hubbblewww/node_modules/email-templates/lib/template-manager.js (os.osx.x86_64)
"node-sass" in /Users/administrator/Dropbox/Development/hubbble/hubbblewww/node_modules/email-templates/lib/template-manager.js (os.osx.x86_64)
If you notice problems related to these missing modules, consider running:

meteor npm install --save emblem less stylus styl node-sass
...

No real problems i've experienced from this, just largely an unnecessary extra message when I have what's needed. I'd imagine its probably better that they are removed from dev depenencies, instead of adding extra bulk to package.json.

@jeduan
Copy link
Contributor

jeduan commented Jun 14, 2016

Those packages are needed to run tests while developing the module. They are also required only when they are used… I wonder what might be going on here.

@myyellowshoe
Copy link
Author

Gotcha, i figured it was something like that. Could consider using optional dependencies: https://docs.npmjs.com/files/package.json#optionaldependencies

@niftylettuce
Copy link
Collaborator

@myyellowshoe still an issue? any luck finding out solution?

@niftylettuce
Copy link
Collaborator

v3.x released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants