Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the version tag correctly #204

Open
xtracko opened this issue Oct 24, 2016 · 1 comment
Open

Update the version tag correctly #204

xtracko opened this issue Oct 24, 2016 · 1 comment
Labels
Milestone

Comments

@xtracko
Copy link
Collaborator

xtracko commented Oct 24, 2016

Eacirc is self version aware - or should be. Make the file verison.h.in to update at every build phase, not just at config phase.

Currently if you run cmake's configure a current commit tag is propagated into version.h file. The if you do a new commit and try to rebuild eacirc, the version.h file is not updated so the previous commit tag is used. To get the correct commit tag (the tag from eacirc was build) you must run cmake's reconfigure.

Ps.: some CMake knowledge is needed.

@xtracko xtracko added the bug label Oct 24, 2016
@xtracko xtracko added this to the Eacirc v4.1 milestone Oct 24, 2016
@Bender250
Copy link
Collaborator

Getting more important with submodules. The cmake is working even less deterministic (I was not able to produce binary with correct current version tag).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants