Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot run with the Blueprint example's sidepanel #3

Open
crolando opened this issue Feb 4, 2023 · 2 comments
Open

Cannot run with the Blueprint example's sidepanel #3

crolando opened this issue Feb 4, 2023 · 2 comments

Comments

@crolando
Copy link
Owner

crolando commented Feb 4, 2023

@adamsepp is designing a way to execute a program that is defined by the nodes. This user has created these forks to implement a scheme for program execution:
https://github.com/adamsepp/nodos_experimental
https://github.com/adamsepp/plano_experimental

@adamsepp I am not able to run your examples. The program dies in the way described here: thedmd/imgui-node-editor#191

I found that I could get it running by disabling the sidepanel. That is, in your plano_experimental frame.cpp file, I got it working by commenting out these lines:

    //Splitter(true, 4.0f, &leftPaneWidth, &rightPaneWidth, 50.0f, 50.0f);

    //ShowLeftPane(leftPaneWidth - 4.0f);

    //ImGui::SameLine(0.0f, 12.0f);

I must apologize, this is not something I understand. I hope in the bug above, we can get to the bottom of it. I can port whatever changes are made there into Plano.

@adamsepp
Copy link

adamsepp commented Feb 5, 2023

Hi @crolando, I'm not sure why the Splitter caused some issues on your side...
I changed the code to use an ImGui::Table instead of Splitter... So it should be ok now....
I have now 3 panels (left = overview; middle = node editor; right = additional settings/info for a node if selected...)

Besides that I commited following changes:

  • BUGFIX: when new node is created directly by link drop (now link always gets linked correctly see "newNodeLinkPinID")
  • new link type "FlowReset" allow nodes to be resetted (to be able to create loops)
  • change node header color according to its state (for better visual effect...) + draw specific node name in node header
  • remove flow worker and let the node function itself start/reset other node (by shared pointer to other nodes)
    -> therefore all node function are updated on each link change -> not super nice, but allow better performance whil running
    -> since each node function running in own thread it should allow high performance
  • each node has now another callback function which draws the content for the right pane

@crolando
Copy link
Owner Author

crolando commented Mar 1, 2023

Note: adamsepp's implementation is in a VS project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants