Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of \DateTimeInterface instead of \DateTime #78

Closed
abouet opened this issue Nov 2, 2022 · 1 comment
Closed

Use of \DateTimeInterface instead of \DateTime #78

abouet opened this issue Nov 2, 2022 · 1 comment

Comments

@abouet
Copy link

abouet commented Nov 2, 2022

Use of \DateTimeInterface instead of \DateTime in CrontabSchedule::valid(), as the date to evaluate might not be a \DateTime object.
besides it complies with POO best pratices.
@NoUseFreak
Copy link
Contributor

Makes sense, feel free to make a pull request

@abouet abouet mentioned this issue Nov 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NoUseFreak @abouet