Add compute unit request to transaction packing algorithm #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There seems be a bug in this implementation. https://explorer.solana.com/tx/ddmGmQugdmkpUp7wQBehHQ2iTA7o6fsRrMTKyitMEGjyE5KcYHvKfVTYAtkcFdJzhM7yrVCABHFf43UdanHK2pD?cluster=devnet |
nickgarfield
added a commit
that referenced
this pull request
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users (specifically, Helium) have been hitting the compute unit limit in their transactions. This PR adds a
ComputeBudgetInstruction::set_compute_unit_limitinstruction to the front of every transaction. During simulation, we request the maximum 1.4M compute units available, giving transactions the flexibility of using as many compute units as they need. After simulation, we update the transaction to request only the compute units that were actually consumed. This way, Clockwork transactions will always request exactly the number of compute units they need. This will help with prioritization when solana-labs/solana#28751 lands on Solana.