Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show users unnecessary manual subscriptions #51

Open
rossjrw opened this issue Sep 12, 2022 · 2 comments
Open

Show users unnecessary manual subscriptions #51

rossjrw opened this issue Sep 12, 2022 · 2 comments
Labels
feature A new feature

Comments

@rossjrw
Copy link
Member

rossjrw commented Sep 12, 2022

Some users subscribe to threads that they don't need to, as they're already covered by the automatic subscription rules. It would be nice to show them a list of such subscriptions such that they can remove them if they choose.

@rossjrw rossjrw added the feature A new feature label Sep 12, 2022
@rossjrw
Copy link
Member Author

rossjrw commented Oct 23, 2023

Similarly to #79, creating this list will not be possible after #85 because I won't be storing users' automatic subscriptions except for those that are actively emitting a notification, and therefore won't be able to compare that list against the manual subscriptions.

That being said, instead of adding a straight-up list to the digest, I can show whether a notification was a match for multiple contexts. If so, and if one of them was a manual subscription, I can advise the user that the manual subscription is unnecessary on a per-notification basis.

@rossjrw
Copy link
Member Author

rossjrw commented Feb 1, 2024

As part of #85 it's looking like (not set in stone yet) the database is going to emit a set of bools per notification indicating which reasons it matched for it to be emitted. I'll be modifying the digester to change the text in the digest based on the presence of one of these flags. I won't be actioning this issue in #85, though, I'll leave it as close to the extant behaviour as possible.

Later I can action this issue specifically by adding special cases for when multiple flags are set on a notification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature
Projects
None yet
Development

No branches or pull requests

1 participant