-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding an option to force loading of d3dx9_43.dll? #22
Comments
Mmh. The error should be made more noticable, I agree. Could display an error messagebox instead of just silently writing a log message ... |
I noticed that before commit: "Clean up code" ( 9eb8faa ) |
This was changed in and because of #16. |
You're right. I double checked it. Seems like I was testing in a wrong folder and I thought it already had #16 :) I'll see if I can revert this change later, or at least add a workaround. |
I would not recommend reverting change #16. Instead you could add two lines to LOG << "Failed to load d3dx9_43.dll! Some features will not work correctly." << std::endl; Add these lines: MessageBox(nullptr, TEXT("Failed to load \"d3dx9_43.dll\"!"), nullptr, MB_ICONWARNING);
return nullptr; That should do what you want. |
Thank you. Seems like this solution is acceptable too :) I made more detailed error message with MB_OKCANCEL, and also ShellExecute with: https://www.microsoft.com/en-us/download/details.aspx?id=8109 when user clicks "OK". It opens the site where the missing "End-User Runtime" can be downloaded. |
Closed in #23. |
Hello. After the last changes, the converter doesn't longer throw an error when "d3dx9_43.dll is missing", when users don't install required DirectX 9 SDKs. In some games it causes graphics bugs like missing/deformed textures: http://i.imgur.com/KwbVZLA.jpg
I would rather want to see an error on game start, than experiencing graphics bugs. Is there any option to force d3dx9_43.dll loading, just as it used to be in previous versions of d3d8to9?
I tried adding d3dx9.lib to additional dependencies, but it doesn't seem to help (still not "missing .dll" error).
The text was updated successfully, but these errors were encountered: