Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wishlist: Add a feature to support installing packages in the Docker image when cross runs #281

Closed
autarch opened this issue Aug 13, 2019 · 3 comments

Comments

@autarch
Copy link

autarch commented Aug 13, 2019

I know I can use custom Docker images for this but creating and maintaining several (possibly 10+) images just to add a git binary seems very heavyweight and painful.

I would think that it'd be possible for cross to invoke apt-get in the image before it calls cargo (or xargo). I could look into implementing this if there's agreement that this is a thing that should be possible.

@autarch autarch changed the title Add a feature to support installing packages in the Docker image when cross runs Wishlist: Add a feature to support installing packages in the Docker image when cross runs Aug 13, 2019
@mainrs
Copy link

mainrs commented Sep 5, 2019

Damn, I was wondering why my builds would constantly fail before I realised I'm running Docker instances 🤷‍♂

Would love if you could implement this! 😄

@mainrs
Copy link

mainrs commented Sep 11, 2019

As using their images doesn't work for my dependencies either, I just forked the project, removed the Dockerfiles that I do not need and bumped them up to xenial which allowed me to install my library dependencies without any issues. I modified the images directly and published them under a new organisation for my project that mentions that the images are only used to cross compile my project.

Edit: I was trying to get it somehow working with Github Actions but I either do not really understand Github Actions and their filesystem interactions or it doesn't work as of now.
I have no clue on how to actually retrieve the compiled binary and upload it as an artifact within the same workflow. I thought that all steps share the same filesystem but it didn't really work for me.

@Alexhuszagh
Copy link
Contributor

This was implemented in #678, and the documentation on how to use pre-build hooks or custom Dockerfiles can be found on the wiki.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants