Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

es6 promise v.s. whenjs: progress #319

Closed
joggienl opened this issue Sep 20, 2017 · 2 comments
Closed

es6 promise v.s. whenjs: progress #319

joggienl opened this issue Sep 20, 2017 · 2 comments

Comments

@joggienl
Copy link
Contributor

Even though not in the official Promise A+ spec, whenjs has (deprecated!) support for progress like results trough calling notify.

Are there plans to improve this behaviour?

I currently have a use case for using progressive results. But if you set the Connection options to use_es6_promises things break:

d.notify(result);
.

I have a specific RPC which I need to call with {receive_progress: true}. It will throw an error on this line.

I'm not sure yet what would be a better way to be able to do progressive results (it is part of the WAMP spec after all). Curious to know I've you have any idea on this already. I don't think it is wise to wait until whenjs drops this from their lib ;-)

@Jopie64
Copy link
Contributor

Jopie64 commented Nov 29, 2017

rxjs observables would be ideal for progressive call results!
I have a use case for progressive results too, and it would be great when they would be implemented with observables instead of with promises.

@oberstet
Copy link
Contributor

progressive results RPC do work and are tested in our CI: https://github.com/crossbario/autobahn-js/blob/master/test/test_rpc_progress.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants