Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build XBR-less library packages #436

Closed
frol opened this issue Jun 8, 2019 · 6 comments
Closed

Build XBR-less library packages #436

frol opened this issue Jun 8, 2019 · 6 comments
Assignees

Comments

@frol
Copy link

frol commented Jun 8, 2019

Could you please shed some light on the "no dependencies" meaning in the README ("Features" section)?

Upgrade of Autobahn-js from 19.4.1 to 19.6.1 blew up my minified application bundle size from 490kb to 2.7MB (uncompressed, yet it is huge). I believe, It is related to #433.

@oberstet oberstet changed the title Clarify "no dependencies" in README Make XBR optional Jun 11, 2019
@oberstet
Copy link
Contributor

Uhh, yes, we probably should build a XBR-less version of AB for bundled use (and when XBR is unneeded)

@oberstet oberstet changed the title Make XBR optional Build XBR-less library packages Jun 11, 2019
@WyriHaximus
Copy link

FYI the truffle-contract in package.json still pulls on the entire (or at least of the) eth/web3 suite it seems.

P.S. Suddenly seeing eth related packages kind of freaked me out for a moment. Especially since there is no documentation mentioning eth or XBR mentioned anywhere in the readme.

@frol
Copy link
Author

frol commented Jun 17, 2019

@WyriHaximus It freaked me out so much that I had even created an issue: crossbario/crossbar-examples#127 😄

@oberstet
Copy link
Contributor

@om26er what we could do is load the json abi files for xbr from the net when the user wants to do xbr stuff. on the other hand, if the user wants to do xbr, then loading the json abi files from the net each time seems less cool. mmh ..

@om26er
Copy link
Contributor

om26er commented Jul 18, 2019

Once #453 lands, the size should come back to previous points. From there we will investigate to reduce size further, see #374

om26er@Intel-NUC-PC:~/scm/crossbario/autobahn-js/packages/autobahn/build$ ls -la
total 1156
drwxrwxr-x 2 om26er om26er   4096 Jul 18 05:22 .
drwxrwxr-x 5 om26er om26er   4096 Jul 18 05:22 ..
-rw-rw-r-- 1 om26er om26er 786648 Jul 18 05:22 autobahn.js
-rw-rw-r-- 1 om26er om26er  84118 Jul 18 05:22 autobahn.min.jgz
-rw-rw-r-- 1 om26er om26er 282312 Jul 18 05:22 autobahn.min.js
-rw-rw-r-- 1 om26er om26er    168 Jul 18 05:22 CHECKSUM.MD5
-rw-rw-r-- 1 om26er om26er    195 Jul 18 05:22 CHECKSUM.SHA1
-rw-rw-r-- 1 om26er om26er    273 Jul 18 05:22 CHECKSUM.SHA256
-rw-rw-r-- 1 om26er om26er   1086 Jul 18 04:58 LICENSE

@oberstet
Copy link
Contributor

fixed via #453

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants