Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subscriptionObject.unsubscribe() vs. session.unsubscribe(subscriptionID) #59

Closed
goeddea opened this issue Mar 4, 2014 · 1 comment
Closed

subscriptionObject.unsubscribe() vs. session.unsubscribe(subscriptionID) #59

goeddea opened this issue Mar 4, 2014 · 1 comment
Labels
enhancement

Comments

@goeddea
Copy link
Contributor

goeddea commented Mar 4, 2014

Presently a subscription is canceled by doing 'subscriptionObject.unsubscribe()'.

To me it would feel more natural to do 'session.unsubscribe(subscriptionID)'

In the latter case, all interactions regarding subscriptions etc. are via the session object.
In the present state of things, unsubscribe and unregister break this pattern.
@oberstet
Copy link
Contributor

alright, but the argument won't be subscriptionID, but a subscription object (an instance of class autobahn.Subscription)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oberstet @goeddea