Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ApplicationRunner should not auto_reconnect after failed login #878

Open
Mahedros opened this issue Aug 10, 2017 · 1 comment
Open

ApplicationRunner should not auto_reconnect after failed login #878

Mahedros opened this issue Aug 10, 2017 · 1 comment

Comments

@Mahedros
Copy link

When auto_reconnect is enabled, the ApplicationRunner does not know whether or not it ever successfully connected in the first place. As a result, connections lost due to incorrect login information are constantly re-attempted with the same incorrect information.

A check that prevents this exists in Autobahn JS:
https://github.com/crossbario/autobahn-js/blob/master/lib/connection.js#L349

@oberstet
Copy link
Contributor

Yep. And this case should also be signaled using a dedicated error URI / reason.

Eg we probably want that in https://github.com/crossbario/autobahn-python/blob/master/autobahn/wamp/exception.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants