"null" value in recommendations/facts

[mhow2]

@valeriocos, when you get a chance, could you help sorting out why there is a null value here ?
XWiki project on http://beta.crossminer.org , scava-overview dashboard.

[valeriocos]

The SCAVA API of the beta instance is not accessible, I used the OW2 one.

The problem comes from the SCAVA API, for instance if we focus on asm, we can see that some facts are empty (http://scava-dev.ow2.org:8601/goto/e7f91332486fcdd0a9b093c3e4fa1d24). If we check the API call (http://scava-dev.ow2.org:8182/projects/p/asm/f), we can see that some factoids are empty.

[
    ...
    {
        "factoid": "The average sentimental polarity in all bug-tracking systems associated with the project is neutral (-0.01 with -1 designating entirely negative sentiment and 1 designating entirely positive sentiment).\nAt the beginning of threads, the average sentiment score is 0, while at the end of threads it is 0.06, showing that users have similar feelings at the end of a discussion as at the beginning of it.\n",
        "id": "org.eclipse.scava.factoid.bugs.sentiment.BugsChannelSentimentFactoid",
        "name": "Bug Tracker Sentiment",
        "stars": "TWO"
    },
    {
        "factoid": "null",
        "id": "trans.rascal.LOC.codeSize",
        "name": "Code Size",
        "stars": "ONE"
    },
    ...
    {
        "factoid": "null",
        "id": "style.errorProneFactoid",
        "name": "Error proneness",
        "stars": "ONE"
    },
   ...
]

[creat89]

Hello,

The null factoids were discussed here #148 (comment) and most of them are related to Rascal Metrics

[mhow2]

Thanks @valeriocos , @creat89
#148 is open since a so long time I forgot about it... @tdegueul can you take a look ?

[tdegueul]

Seems like it's definitely an issue on our side; I'll investigate.

[tdegueul]

ebc556a should hopefully fix the issue.

[valeriocos]

@mhow2 can you check if the issue is solved on your side? thanks

[borisbaldassari]

I'm sorry but as far as I can tell the issue can still be seen in the recent updates.
@valeriocos @mhow2 do you confirm?

[mhow2]

Sorry for the delay @valeriocos
Well, it's hard to tell if the issue is solved on my side because I'm not wiping the ES data, I'm just updating it with new material as I don't want to loose anything of the history. (said differently, I haven't destroyed the kibiter container since a very long time).

[creat89]

I don't know which is the mapping that it is being used by the factoids in Kibana/ES, which are the recommendations and facts, but if for whatever reason the ID of the entry is null, it will never disappear, but another entry should appear. The reason is that ES might not be possible to find the entry to update.

[valeriocos]

Based on the null value that appears at http://scava-dev.ow2.org:8601/goto/de347159f8e8f4b7a9617c537fcc358e for the project RocketChat in date 20191103, I have set up an analysis (http://crossminer.bitergia.net:5601/#/project/configure/RocketChat) on the Bitergia instance.

I'll report on the results as soon as the analysis is over.

[valeriocos]

The error is still there:

[creat89]

I checked the code to try to help you, but I couldn't find anything that could trigger a null. As you can see in https://github.com/crossminer/scava/blob/dev/metric-platform/metric-providers/org.eclipse.scava.metricprovider.trans.rascal.LOC/src/LOC.rsc the text is defined and sent to the function factoid(txt, starts)

[valeriocos]

Thanks @creat89 , I'm going to check if the error is on the scava2es importer and report back to you.

[valeriocos]

The error isn't in the scava2es. Find below the endpoints with null value. @tdegueul, I can easily filter such values during the migration from scava to ES (if needed).

endpoints:

• http://crossminer.bitergia.net:8182/projects/p/RocketChat/f/trans.rascal.CC.java.CCJavaFactoid
• http://crossminer.bitergia.net:8182/projects/p/RocketChat/f/trans.rascal.LOC.codeSize
• http://crossminer.bitergia.net:8182/projects/p/RocketChat/f/trans.rascal.OO.java.Cohesion-Java
• http://crossminer.bitergia.net:8182/projects/p/RocketChat/f/trans.rascal.OO.java.Coupling-Java
• http://crossminer.bitergia.net:8182/projects/p/RocketChat/f/rascal.testability.java.JavaUnitTestCoverage
• http://crossminer.bitergia.net:8182/projects/p/RocketChat/f/trans.rascal.clones.cloneCode
• http://crossminer.bitergia.net:8182/projects/p/RocketChat/f/trans.rascal.comments.commentPercentage
• http://crossminer.bitergia.net:8182/projects/p/RocketChat/f/trans.rascal.comments.headerUse
• http://crossminer.bitergia.net:8182/projects/p/RocketChat/f/trans.rascal.comments.percentageCommentedOutCode
• http://crossminer.bitergia.net:8182/projects/p/RocketChat/f/trans.rascal.readability.ReadabilityFactoid