New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make patch type required #19
Comments
In this case, the migration from the current Crosslane core P&T will be more than just indenting the yaml :) |
This could be added to https://github.com/crossplane-contrib/crossplane-migrator in the same we we populate missing ConnectionSecret keys. |
Added issue here crossplane-contrib/crossplane-migrator#6 |
I've merged the fix to the migrator:
|
I'm kind of feeling like the ship has sailed on this one. There's enough folks using this function now that we probably can't make such a breaking change easily. I feel okay leaving it as is - let me know if anyone disagrees. |
See discussion at #16 (comment).
This would almost certainly make porting to
function-patch-and-transform
more of a pain for most folks, but it may be worth it to make P&T Compositions more explicit and readable in future.The text was updated successfully, but these errors were encountered: