Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make patch type required #19

Closed
negz opened this issue Oct 11, 2023 · 5 comments
Closed

Make patch type required #19

negz opened this issue Oct 11, 2023 · 5 comments

Comments

@negz
Copy link
Member

negz commented Oct 11, 2023

See discussion at #16 (comment).

This would almost certainly make porting to function-patch-and-transform more of a pain for most folks, but it may be worth it to make P&T Compositions more explicit and readable in future.

@ytsarev
Copy link
Contributor

ytsarev commented Oct 12, 2023

In this case, the migration from the current Crosslane core P&T will be more than just indenting the yaml :)
I believe it's ok, just needs to be documented somewhere explicitly.

@stevendborrelli
Copy link
Collaborator

This could be added to https://github.com/crossplane-contrib/crossplane-migrator in the same we we populate missing ConnectionSecret keys.

@stevendborrelli
Copy link
Collaborator

Added issue here crossplane-contrib/crossplane-migrator#6

@stevendborrelli
Copy link
Collaborator

I've merged the fix to the migrator:

  • the migrator will add missing transform types
  • if the patch type is not specified it will add the default type
  • it will generate a name for the resource if not specified

@negz
Copy link
Member Author

negz commented Jan 2, 2024

I'm kind of feeling like the ship has sailed on this one. There's enough folks using this function now that we probably can't make such a breaking change easily. I feel okay leaving it as is - let me know if anyone disagrees.

@negz negz closed this as completed Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants