-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reusable Package #52
Comments
I think it would be a good idea, as other folks can use the logic in their own functions if needed. |
A few questions if we did this:
|
My initial thoughts were that it would live in this repo in a subdir with a package name of |
I am leaning into a separate repo due to the sync issues we are starting to see with upstream P&T and concerns about deprecation. It would be nice if upstream, the P&T function and any forks share common code. We could ensure existing P&T users that the function behavior is equivalent. |
I still feel pretty bullish on removing the native P&T code from Crossplane. So personally I would not factor in needing to support a library used by both Crossplane core and this function. I could imagine emulating native P&T support by transparently using a function inside of Crossplane. |
I'm wary of making a reusable patch and transform library. I'd like to hear more about how folks think it would be used. My primary concerns are:
FWIW I don't think the fact that the code here duplicates the P&T code in c/c is a compelling reason to create a library. I'm also a little concerned about drift between the two implementations, but I hope to address that by freezing and one day removing the c/c P&T functionality. |
@negz I would agree with you. I've since found alternative solutions to what I was trying to do that no longer requires P&T. I'd be fine with closing this if no one else has any issues. |
After thinking about it for a while I still don't feel good about proceeding here. My understanding is that right now only one known consumer that wants this change (https://github.com/MisterMX/crossplane-function-server). Given that, I don't want to change the contract of this function for now (i.e. for it to become a library). If we find that there ends up with more than a small handful of forks of this function we can revisit. |
Any chance of moving the patching logic to an importable package? I would like to reuse the patching logic in a function that I am working on, but cannot because it is part of the
main
package. I could work on a PR if this is doable.The text was updated successfully, but these errors were encountered: