feat(database/rds): Add password constraints #1734
Conversation
Signed-off-by: Maximilian Blatt <maximilian.blatt-extern@deutschebahn.com> (external expert on behalf of DB Netz AG)
Signed-off-by: Maximilian Blatt <maximilian.blatt-extern@deutschebahn.com> (external expert on behalf of DB Netz AG)
Signed-off-by: Maximilian Blatt (external expert on behalf of DB Netz) <maximilian.blatt-extern@deutschebahn.com>
MisterMX
force-pushed
the
feat/password-constraints
branch
from
4e4019e
to
d4a6081
Compare
| @@ -141,6 +143,10 @@ type CustomDBClusterParameters struct { | |||
| // Constraints: Must contain from 8 to 100 characters. | |||
| MasterUserPasswordSecretRef *xpv1.SecretKeySelector `json:"masterUserPasswordSecretRef,omitempty"` | |||
|
|
|||
| // MasterUserPaswordConstraints specifies additional constraints | |||
| // that apply to the password referenced by MasterUserPasswordSecretRef. | |||
| MasterUserPaswordConstraints *common.PasswordConstraints `json:"masterUserPaswordConstraints,omitempty"` | |||
There was a problem hiding this comment.
typo, two "s" in password
|
I wonder if it would be better to just make the default passwords really good (enough for 95% of users), and have the final 5% just pre-generate a password (provider-secret-password? 😄) with features like this. |
I really like that thought. However, we do allow our users to specify their own passwords so we need it to be checked. And I think the provider is the best place to do that. Would it still be possible to get theses changes merged? |
I think this is a fairly special case, I'd leave it to @haarchri to decide. I think the best practise is to generate a random master password and never expose it to humans, only use it in other tooling to create less privileged users, so this feature is normally not a requirement. |
|
have the same feeling than @chlunde |
|
Closing it since this use case is too specific. |
Description of your changes
This adds the ability to set additional password constraints for
DBCluster.docdb,DBInstance.rds,DBCluster.rdsandRDSInstance.database.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Unit tests.