CognitoIDP[UserPoolClient]: UserPoolClient name has unexpected validation errors when contains uppercase / non word characters

[thekaleidoscope]

What happened?

As a side effect of 762, the UserPoolClient name now throws a validation error when the name contains any special characters like - or .. Client Name doesn't have such restrictions according to AWS Docs

The validation rules of Client ID [\w+]+, now applies on top of validation rules of Client Name.

How can we reproduce it?

Create a user pool client with nameorg-name, This will error out with:

observe failed: cannot run refresh: refresh failed: reading Amazon
        Cognito IDP (Identity Provider) User Pool Client (org-name):
        InvalidParameterException: 1 validation error detected: Value
        'org-name` at 'clientId' failed to satisfy constraint: Member must
        satisfy regular expression pattern: [\w+]+

What environment did it happen in?

• Crossplane Version: v1.10.4
• Provider Version: v0.38.0
• Kubernetes Version: v1.23.17
• Kubernetes Distribution: EKS

[thekaleidoscope]

As mentioned in 762, I think a viable solution could be making a MD5 of the name as its of regex [0-9a-f]{32} satisfies both the requirements, I'll be happy to make the PR if this makes sense

[turkenf]

Hi @thekaleidoscope,

Thank you for raising this issue, it can be reproduced with provider-aws v0.39.0. I also faced the same issue while working on this issue.

[mbbush]

When generating an invalid name to use as the initial terraform id, that will just be overwritten later, is there any reason why we can't just use a static value? That seems simpler and no less "wrong" than other solutions like using the name or hashing.