Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Managed Reconciler: A resource with unresolved references never gets deleted #62

Closed
soorena776 opened this issue Oct 28, 2019 · 1 comment · Fixed by #70
Closed

Managed Reconciler: A resource with unresolved references never gets deleted #62

soorena776 opened this issue Oct 28, 2019 · 1 comment · Fixed by #70
Assignees
@negz
Labels
bug Something isn't working

Comments

@soorena776
Copy link
Contributor

soorena776 commented Oct 28, 2019 •
edited
Loading

What happened?

Currently if a managed resource has unresolved references, it never gets deleted, because it exits the reconciliation loop early.

How can we reproduce it?

  • create a resource which has references that doesn't exist (for example a Subnetwork with a network reference NetworkRef that doesn't exist)
  • delete the Subnetwork resource
  • observe that Subnetwork never gets deleted

What environment did it happen in?

Crossplane version: crossplaneio/crossplane-runtime,master@6916b94
@soorena776 soorena776 added the bug Something isn't working label Oct 28, 2019
@soorena776
Copy link
Contributor Author

Adding @negz and @jbw976 for visibility.

@muvaf muvaf mentioned this issue Oct 28, 2019
Closed
@soorena776 soorena776 mentioned this issue Oct 28, 2019
Closed
4 tasks
@negz negz self-assigned this Oct 30, 2019
This was referenced Oct 31, 2019
Closed
Merged
@negz negz closed this as completed in #70 Nov 4, 2019
This was referenced Nov 4, 2019
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@negz negz

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@negz @soorena776