Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a way to pause reconciliation of individual resources #2590

Closed
turkenh opened this issue Sep 23, 2021 · 5 comments
Closed

Need a way to pause reconciliation of individual resources #2590

turkenh opened this issue Sep 23, 2021 · 5 comments
Labels
enhancement New feature or request needs-design

Comments

@turkenh
Copy link
Member

turkenh commented Sep 23, 2021

What problem are you facing?

Recently, while I was working on the migration guide for provider-gcp, I needed a way to make sure that no crossplane or provider controllers reconcile on some custom resources (managed, composite, configuration etc). However, currently, we don't have such an option today to pause reconciliation hence I had to scale down controller pods to 0.

How could Crossplane help solve your problem?

Introduce a way to pause reconciliation on resources and ACK this in the status so that user could make sure that crossplane will no longer take any action for that resource.

We could use an annotation like the following:

crossplane.io/paused: "true"
@turkenh turkenh added the enhancement New feature or request label Sep 23, 2021
@negz
Copy link
Member

negz commented Sep 23, 2021

I've been kind of hesitant about this in the past, but only because I worry that folks might accidentally miss that some MRs are paused. I wonder if we could solve that with events/metrics? e.g. Perhaps when this annotation existed the managed resource reconciler could return early without actually doing any meaningful reconciling, but emit a Paused event. We could also potentially add a new conditioned status type (e.g. Paused).

@negz
Copy link
Member

negz commented Oct 11, 2021

"Needs design" is possibly a bit much for this one - alignment and discussion in this issue may be sufficient.

@stale
Copy link

stale bot commented Aug 14, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@praveenadini
Copy link

Hi Team, We are facing the same issue with pausing reconcile on claims or the MR's created by claims. Is there any fix that is available to achieve this.

@bobh66
Copy link
Contributor

bobh66 commented Aug 19, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-design
Projects
None yet
Development

No branches or pull requests

4 participants