Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have crossplane beta render emit debug logs #4809

Closed
Tracked by #4654
negz opened this issue Oct 13, 2023 · 3 comments · Fixed by #5328
Closed
Tracked by #4654

Have crossplane beta render emit debug logs #4809

negz opened this issue Oct 13, 2023 · 3 comments · Fixed by #5328
Labels

Comments

@negz
Copy link
Member

negz commented Oct 13, 2023

What problem are you facing?

Today crossplane beta render doesn't log much (anything?). There's a bunch of TODOs in the codebase where it would be useful to do so - e.g. if we can't stop a Function running as a Docker container.

How could Crossplane help solve your problem?

We should add some debug logging statements. Given that the command's main job is to print stuff to stdout we probably need to be careful about logging. I imagine we don't want to log anything in the happy path, and if we do hit issues we want to make sure they're going to stderr so the caller can filter output from logs.

Copy link

Crossplane does not currently have enough maintainers to address every issue and pull request. This issue has been automatically marked as stale because it has had no activity in the last 90 days. It will be closed in 14 days if no further activity occurs. Leaving a comment starting with /fresh will mark this issue as not stale.

@github-actions github-actions bot added the stale label Jan 12, 2024
@jbw976
Copy link
Member

jbw976 commented Jan 12, 2024

/fresh

@github-actions github-actions bot removed the stale label Jan 12, 2024
@jbw976 jbw976 removed this from the v1.15 milestone Jan 24, 2024
@phisco
Copy link
Contributor

phisco commented Jan 30, 2024

Logging to stderr should be enough to avoid confusion with the actual output, wdyt @negz?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants