Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearly state that connectionSecretKeys is immutable #456

Closed
plumbis opened this issue May 30, 2023 · 2 comments · Fixed by #475
Closed

Clearly state that connectionSecretKeys is immutable #456

plumbis opened this issue May 30, 2023 · 2 comments · Fixed by #475
Assignees
Labels
concepts/composition content request Issues requesting new content docs User docs related issues and content

Comments

@plumbis
Copy link
Collaborator

plumbis commented May 30, 2023

There is confusion around connectionSecretKeys. There are two spots where it's discussed today:
https://docs.crossplane.io/v1.12/concepts/composition/#hl-6-22
https://docs.crossplane.io/v1.12/concepts/composition/#composite-resource-connection-secrets

Make sure to clarify that this is immutable in the Composite Resources update.

@plumbis plumbis added content request Issues requesting new content docs User docs related issues and content concepts/composition labels May 30, 2023
@aroramrinaal
Copy link

hey @plumbis ,
Can I work on this issue?

@plumbis
Copy link
Collaborator Author

plumbis commented Jun 21, 2023

Thanks for volunteering @aroramrinaal! For this issue, it's going to be fixed by a much larger rewrite of the entire Composition chapter, aiming to fix all the concepts/composition issues.

@plumbis plumbis self-assigned this Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
concepts/composition content request Issues requesting new content docs User docs related issues and content
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants