-
Notifications
You must be signed in to change notification settings - Fork 362
/
bucketpolicy.go
199 lines (169 loc) · 6.75 KB
/
bucketpolicy.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
/*
Copyright 2020 The Crossplane Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package bucketpolicy
import (
"context"
"encoding/json"
"time"
"github.com/aws/aws-sdk-go-v2/aws"
awss3 "github.com/aws/aws-sdk-go-v2/service/s3"
"github.com/google/go-cmp/cmp"
"github.com/pkg/errors"
"k8s.io/client-go/util/workqueue"
ctrl "sigs.k8s.io/controller-runtime"
"sigs.k8s.io/controller-runtime/pkg/client"
"sigs.k8s.io/controller-runtime/pkg/controller"
xpv1 "github.com/crossplane/crossplane-runtime/apis/common/v1"
"github.com/crossplane/crossplane-runtime/pkg/event"
"github.com/crossplane/crossplane-runtime/pkg/logging"
"github.com/crossplane/crossplane-runtime/pkg/ratelimiter"
"github.com/crossplane/crossplane-runtime/pkg/reconciler/managed"
"github.com/crossplane/crossplane-runtime/pkg/resource"
"github.com/crossplane/provider-aws/apis/s3/v1alpha3"
awsclient "github.com/crossplane/provider-aws/pkg/clients"
"github.com/crossplane/provider-aws/pkg/clients/s3"
)
const (
errUnexpectedObject = "The managed resource is not a BucketPolicy resource"
errAttach = "failed to attach the policy to bucket"
errDelete = "failed to delete the policy for bucket"
errGet = "failed to get BucketPolicy for bucket with name"
errUpdate = "failed to update the policy for bucket"
errNotSpecified = "failed to format bucketPolicy, no rawPolicy or policy specified"
)
// SetupBucketPolicy adds a controller that reconciles
// BucketPolicies.
func SetupBucketPolicy(mgr ctrl.Manager, l logging.Logger, rl workqueue.RateLimiter, poll time.Duration) error {
name := managed.ControllerName(v1alpha3.BucketPolicyGroupKind)
return ctrl.NewControllerManagedBy(mgr).
Named(name).
WithOptions(controller.Options{
RateLimiter: ratelimiter.NewController(rl),
}).
For(&v1alpha3.BucketPolicy{}).
Complete(managed.NewReconciler(mgr,
resource.ManagedKind(v1alpha3.BucketPolicyGroupVersionKind),
managed.WithExternalConnecter(&connector{kube: mgr.GetClient(),
newClientFn: s3.NewBucketPolicyClient}),
managed.WithReferenceResolver(managed.NewAPISimpleReferenceResolver(mgr.GetClient())),
managed.WithPollInterval(poll),
managed.WithLogger(l.WithValues("controller", name)),
managed.WithRecorder(event.NewAPIRecorder(mgr.GetEventRecorderFor(name)))))
}
type connector struct {
kube client.Client
newClientFn func(config aws.Config) s3.BucketPolicyClient
}
func (c *connector) Connect(ctx context.Context, mg resource.Managed) (managed.ExternalClient, error) {
cr, ok := mg.(*v1alpha3.BucketPolicy)
if !ok {
return nil, errors.New(errUnexpectedObject)
}
cfg, err := awsclient.GetConfig(ctx, c.kube, mg, cr.Spec.Parameters.Region)
if err != nil {
return nil, err
}
return &external{client: c.newClientFn(*cfg), kube: c.kube}, nil
}
type external struct {
client s3.BucketPolicyClient
kube client.Client
}
func (e *external) Observe(ctx context.Context, mgd resource.Managed) (managed.ExternalObservation, error) {
cr, ok := mgd.(*v1alpha3.BucketPolicy)
if !ok {
return managed.ExternalObservation{}, errors.New(errUnexpectedObject)
}
resp, err := e.client.GetBucketPolicy(ctx, &awss3.GetBucketPolicyInput{
Bucket: cr.Spec.Parameters.BucketName,
})
if err != nil {
if s3.IsErrorBucketNotFound(err) {
return managed.ExternalObservation{}, nil
}
return managed.ExternalObservation{}, awsclient.Wrap(resource.Ignore(s3.IsErrorPolicyNotFound, err), errGet)
}
policyData, err := e.formatBucketPolicy(cr)
if err != nil {
return managed.ExternalObservation{}, awsclient.Wrap(resource.Ignore(s3.IsErrorPolicyNotFound, err), errGet)
}
cr.SetConditions(xpv1.Available())
// If our version and the external version are the same, we return ResourceUpToDate: true
return managed.ExternalObservation{
ResourceExists: true,
ResourceUpToDate: cmp.Equal(*policyData, *resp.Policy),
}, nil
}
// formatBucketPolicy parses and formats the bucket.Spec.BucketPolicy struct
func (e *external) formatBucketPolicy(original *v1alpha3.BucketPolicy) (*string, error) {
if original == nil {
return nil, errors.New(errNotSpecified)
}
switch {
case original.Spec.Parameters.RawPolicy != nil:
return original.Spec.Parameters.RawPolicy, nil
case original.Spec.Parameters.Policy != nil:
c := original.DeepCopy()
body, err := s3.Serialize(c.Spec.Parameters.Policy)
if err != nil {
return nil, err
}
byteData, err := json.Marshal(body)
if err != nil {
return nil, err
}
str := string(byteData)
return &str, nil
}
return nil, errors.New(errNotSpecified)
}
func (e *external) Create(ctx context.Context, mgd resource.Managed) (managed.ExternalCreation, error) {
cr, ok := mgd.(*v1alpha3.BucketPolicy)
if !ok {
return managed.ExternalCreation{}, errors.New(errUnexpectedObject)
}
cr.SetConditions(xpv1.Creating())
policyData, err := e.formatBucketPolicy(cr)
if err != nil {
return managed.ExternalCreation{}, awsclient.Wrap(err, errAttach)
}
policyString := *policyData
_, err = e.client.PutBucketPolicy(ctx, &awss3.PutBucketPolicyInput{Bucket: cr.Spec.Parameters.BucketName, Policy: awsclient.String(policyString)})
return managed.ExternalCreation{}, awsclient.Wrap(err, errAttach)
}
// Update patches the existing policy for the bucket with the policy in the request body
func (e *external) Update(ctx context.Context, mgd resource.Managed) (managed.ExternalUpdate, error) {
cr, ok := mgd.(*v1alpha3.BucketPolicy)
if !ok {
return managed.ExternalUpdate{}, errors.New(errUnexpectedObject)
}
policyData, err := e.formatBucketPolicy(cr)
if err != nil {
return managed.ExternalUpdate{}, awsclient.Wrap(err, errUpdate)
}
_, err = e.client.PutBucketPolicy(ctx, &awss3.PutBucketPolicyInput{Bucket: cr.Spec.Parameters.BucketName, Policy: awsclient.String(*policyData)})
return managed.ExternalUpdate{}, awsclient.Wrap(err, errUpdate)
}
// Delete removes the existing policy for a bucket
func (e *external) Delete(ctx context.Context, mgd resource.Managed) error {
cr, ok := mgd.(*v1alpha3.BucketPolicy)
if !ok {
return errors.New(errUnexpectedObject)
}
cr.SetConditions(xpv1.Deleting())
_, err := e.client.DeleteBucketPolicy(ctx, &awss3.DeleteBucketPolicyInput{Bucket: cr.Spec.Parameters.BucketName})
if s3.IsErrorBucketNotFound(err) {
return nil
}
return awsclient.Wrap(resource.Ignore(s3.IsErrorPolicyNotFound, err), errDelete)
}