New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for CloudSearch #1016
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mhoff for your contribution! Good first PR.
I added some remarks to your code.
Many thanks for your remarks! I have resolved the few minor ones and will continue with the rest. |
88b599d
to
4ada4a4
Compare
@haarchri I have updated the PR according to what we have discussed. This PR should properly implement alpha-support for AWS CloudSearch. Review would be very much appreciated. |
42f0e71
to
a29ad0b
Compare
3e5717d
to
dd33147
Compare
Signed-off-by: Michael Hoff <michael.hoff-extern@deutschebahn.com> (external expert on behalf of DB Netz AG)
…d metadata.name Signed-off-by: haarchri <chhaar30@googlemail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @mhoff thanks for contribution and all changes & rebases
…ne-3.x Update alpine Docker tag to v3.19.0
Description of your changes
Implements basic support for CloudSearch domains.
Some implementation details still up for discussion.
Fixes #1007.
I have:
make reviewable test
to ensure this PR is ready for review.I will:
How has this code been tested
Simple create/delete/update procedures with test resources.
End-to-end testing from creating a domain up to using it to query data using curl and anonymous access (index fields not covered by this PR).
Discussion
The AWS API for CloudSearch does provide a lean data model for Domains (name, region, current scaling values, endpoints). Other parameters (like scaling options, access policy, availability options, index fields) are handled through separate Define/Describe functions, which therefore are excluded from the generated domain data model.
In this PR, I chose the approach to include some of those parameters in the custom domain parameters and to use (sometimes contextless) sub-calls to handle late-init, isUpToDate and update.