Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(amp): added prometheusservice amp workspace #1054

Merged
merged 1 commit into from Mar 8, 2022

Conversation

haarchri
Copy link
Member

@haarchri haarchri commented Jan 5, 2022

Signed-off-by: haarchri chhaar30@googlemail.com

Description of your changes

added prometheusservice/amp workspaces

Fixes parts of #977

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

NAME      READY   SYNCED   EXTERNAL-NAME
example   True    True     ws-b76772c8-bf88-4408-b3aa-4c2479fa8d81
kubectl describe workspace.prometheusservice.aws.crossplane.io/example
Name:         example
Namespace:    
Labels:       <none>
Annotations:  crossplane.io/external-create-pending: 2022-03-07T18:02:06+01:00
              crossplane.io/external-create-succeeded: 2022-03-07T18:02:06+01:00
              crossplane.io/external-name: ws-d8d7475f-217d-4cec-b1ec-bfe740fb4f16
API Version:  prometheusservice.aws.crossplane.io/v1alpha1
Kind:         Workspace
Metadata:
  Creation Timestamp:  2022-03-07T17:02:06Z
  Finalizers:
    finalizer.managedresource.crossplane.io
  Generation:  2
  Resource Version:  354544
  UID:               d3ef1362-e817-40f8-956f-c4adc4b0919b
Spec:
  Deletion Policy:  Delete
  For Provider:
    Alias:   example
    Region:  us-east-1
    Tags:
      Crossplane - Kind:            workspace.prometheusservice.aws.crossplane.io
      Crossplane - Name:            example
      Crossplane - Providerconfig:  example
  Provider Config Ref:
    Name:  example
Status:
  At Provider:
    Arn:                  arn:aws:aps:us-east-1:436715084175:workspace/ws-d8d7475f-217d-4cec-b1ec-bfe740fb4f16
    Prometheus Endpoint:  https://aps-workspaces.us-east-1.amazonaws.com/workspaces/ws-d8d7475f-217d-4cec-b1ec-bfe740fb4f16/
    Status:
      Status Code:  ACTIVE
    Workspace ID:   ws-d8d7475f-217d-4cec-b1ec-bfe740fb4f16
  Conditions:
    Last Transition Time:  2022-03-07T17:02:07Z
    Reason:                Available
    Status:                True
    Type:                  Ready
    Last Transition Time:  2022-03-07T17:02:07Z
    Reason:                ReconcileSuccess
    Status:                True
    Type:                  Synced
Events:

image

…agger

Signed-off-by: haarchri <chhaar30@googlemail.com>
Copy link
Collaborator

@AaronME AaronME left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Created, destroyed, and tested connection secret. All tests passed.

Thanks, @haarchri.

@haarchri haarchri merged commit f1fbca2 into crossplane-contrib:master Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants